Geometry Factory for Muon Calorimeter#1302
Open
ethancline wants to merge 15 commits into
Open
Conversation
… dedicated mu package
ethancline
requested review from
baltzell,
drewkenjo and
raffaelladevita
as code owners
baltzell
reviewed
Jun 3, 2026
|
|
||
| /** | ||
| * | ||
| * @author kenjo |
Collaborator
There was a problem hiding this comment.
Is this the correct author?
baltzell
reviewed
Jun 3, 2026
|
|
||
| private Geant4Basic getLayer(int isec, int isuper, int ilayer) { | ||
| return getRegion(isec, isuper/2).getChildren().get((isuper%2)*6 + ilayer); | ||
| return getRegion(isec, isuper/2).getChildren().get(0).getChildren().get((isuper%2)*6 + ilayer); |
Collaborator
There was a problem hiding this comment.
Should there be a comment about "why the get(0)"?
raffaelladevita
requested changes
Jun 4, 2026
Collaborator
There was a problem hiding this comment.
the DC factory should not be part of this PR
| */ | ||
| public final class MUCALGeant4Factory extends Geant4Factory { | ||
|
|
||
| private final double motherGap = 4.0 * Length.cm; |
Collaborator
There was a problem hiding this comment.
lines 31-47 seem to be leftovers of the FTOF factory that was used as an example to start from, and could be removed
| // private final double[] mucal_oradius = { CrmaxU + 40*microgap, CrmaxD + 40*microgap }; | ||
| private final int[] nPaddles = new int[stringLayers.length]; | ||
|
|
||
| private final int npaddles = 48; |
| private List<G4Trd> createLayer(ConstantProvider cp, int layer) { | ||
|
|
||
|
|
||
| double Dat25deg = 596.*Length.mm; // distance of the upstream face from the target at 25 deg |
|
|
||
| double Dat25deg = 596.*Length.mm; // distance of the upstream face from the target at 25 deg | ||
| double ThetaU = Math.toRadians(25); // deg | ||
| double ThetaMin = Math.toRadians(7); // deg |
Collaborator
There was a problem hiding this comment.
aren't the crystal parameters already defined above?
| double microgap = 0.5*Length.mm; | ||
| double Cwidth = (CwidthU+CwidthD)/2. + microgap; | ||
| int nCrystal = 2*((int)(CrmaxU / Cwidth)+100);// add 100 to get full coverage | ||
| double paddlewidth = 10*Length.cm; |
| return paddleVolumes; | ||
| } | ||
|
|
||
| public G4Box getComponent(int sector, int layer, int paddle) { |
Collaborator
There was a problem hiding this comment.
zg4Box should be replaced with G4Trd
| throw new IndexOutOfBoundsException(); | ||
| } | ||
|
|
||
| public double getThickness(int sector, int layer, int paddle) { |
Collaborator
There was a problem hiding this comment.
this and the following three methods can be removed
| private final double CrmaxD = CrmaxU + Clength*Math.tan(CexitAngle); | ||
|
|
||
|
|
||
| private final double nplanes = 4; |
Collaborator
There was a problem hiding this comment.
is the polucone containing the crystals created?
| double centerX, centerY, x12, x22, y12, y22, rad1, rad2, rad3, rad4, rxy; | ||
| double centerZ, thetaX, thetaY, radius, posX, posY, posZ, dx1, dx2, dz; | ||
| String vname; | ||
| List<G4Trd> paddleVolumes = new ArrayList<>(); |
Collaborator
There was a problem hiding this comment.
maybe replace paddle with crystal?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of Muon Calorimeter Geometry Factory for the future ddvcs experiment.